feat: Support Private CA for server certificates. #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hessjcg
force-pushed
the
customer-ca-support
branch
4 times, most recently
from
2bb7dde to
eba701f
Compare
jackwotherspoon
requested changes
Jan 8, 2025
Collaborator
jackwotherspoon
left a comment
jackwotherspoon
left a comment
There was a problem hiding this comment.
Let's make sure to add the integration test to all 3 flavors: .ts, .mjs and .cjs files
hessjcg
force-pushed
the
customer-ca-support
branch
2 times, most recently
from
a39c7fb to
2724b5e
Compare
hessjcg
force-pushed
the
customer-ca-support
branch
from
2724b5e to
b3e86ef
Compare
Collaborator
Author
|
The mjs & cjs system tests are no longer required thanks to #412 |
hessjcg
force-pushed
the
customer-ca-support
branch
from
b3e86ef to
183ff64
Compare
hessjcg
force-pushed
the
customer-ca-support
branch
from
183ff64 to
64a3d17
Compare
Collaborator
|
Looks like tests are not happy... |
src/socket.ts
Outdated
| ) { | ||
| return (hostname: string, cert: tls.PeerCertificate): Error | undefined => { | ||
| if (serverCaMode === 'GOOGLE_MANAGED_CAS_CA') { | ||
| if (!serverCaMode || serverCaMode !== 'GOOGLE_MANAGED_INTERNAL_CA') { |
Collaborator
There was a problem hiding this comment.
i wonder if for this being undefined is causing issues potentially...
Collaborator
Author
There was a problem hiding this comment.
Tests were failing due to a logic error. I fixed it: !serverCaMode || serverCaMode === 'GOOGLE_MANAGED_INTERNAL_CA'
test: Integration test for Customer Private CA CAS instance.
hessjcg
force-pushed
the
customer-ca-support
branch
from
64a3d17 to
c4a031c
Compare
hessjcg
added a commit
to GoogleCloudPlatform/cloud-sql-go-connector
that referenced
this pull request
Jan 10, 2025
…om CA validation (#910) Going forward, both GOOGLE_MANAGED_CAS_CA, CUSTOMER_MANAGED_CAS_CA, and future new kinds of CA will use standard TLS domain name validation using the server certificate SAN records. The certificate validation logic for the original GOOGLE_MANAGED_INTERNAL_CA is now the exception. See implementation in other connectors: feat: Support Private CA for server certificates. GoogleCloudPlatform/cloud-sql-nodejs-connector#408 feat: Support Customer CAS Private CA for server certificates. GoogleCloudPlatform/cloud-sql-jdbc-socket-factory#2095
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support TLS validation on instances configured with a customer-managed private CA. Includes integration test.